]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
environment: Make more explicit what are the default values
authorAlessandro Bono <alessandro.bono369@gmail.com>
Thu, 5 Sep 2024 12:41:30 +0000 (14:41 +0200)
committerMarge Bot <marge-bot@gnome.org>
Fri, 6 Sep 2024 13:01:39 +0000 (13:01 +0000)
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2986>

js/ui/environment.js

index 24e52d73917414655687a2a65c0a443e189d66a1..784a4527109e23dc14d5b36ecbb1df7a94b5f41b 100644 (file)
@@ -90,6 +90,12 @@ function _getPropertyTarget(actor, propName) {
 }
 
 function _easeActor(actor, params) {
+    params = {
+        repeatCount: 0,
+        autoReverse: false,
+        ...params,
+    };
+
     actor.save_easing_state();
 
     if (params.duration !== undefined)
@@ -100,14 +106,10 @@ function _easeActor(actor, params) {
         actor.set_easing_delay(params.delay);
     delete params.delay;
 
-    let repeatCount = 0;
-    if (params.repeatCount !== undefined)
-        repeatCount = params.repeatCount;
+    const repeatCount = params.repeatCount;
     delete params.repeatCount;
 
-    let autoReverse = false;
-    if (params.autoReverse !== undefined)
-        autoReverse = params.autoReverse;
+    const autoReverse = params.autoReverse;
     delete params.autoReverse;
 
     // repeatCount doesn't include the initial iteration
@@ -157,6 +159,12 @@ function _easeActor(actor, params) {
 }
 
 function _easeActorProperty(actor, propName, target, params) {
+    params = {
+        repeatCount: 0,
+        autoReverse: false,
+        ...params,
+    };
+
     // Avoid pointless difference with ease()
     if (params.mode)
         params.progress_mode = params.mode;
@@ -166,14 +174,10 @@ function _easeActorProperty(actor, propName, target, params) {
         params.duration = adjustAnimationTime(params.duration);
     let duration = Math.floor(params.duration || 0);
 
-    let repeatCount = 0;
-    if (params.repeatCount !== undefined)
-        repeatCount = params.repeatCount;
+    const repeatCount = params.repeatCount;
     delete params.repeatCount;
 
-    let autoReverse = false;
-    if (params.autoReverse !== undefined)
-        autoReverse = params.autoReverse;
+    const autoReverse = params.autoReverse;
     delete params.autoReverse;
 
     // repeatCount doesn't include the initial iteration